Skip to content

Conversation

edonehoo
Copy link
Collaborator

@edonehoo edonehoo commented Aug 1, 2025

Works towards #4622

But remaining pr is needed to update tokens table description to close the og issue

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 1, 2025

@edonehoo edonehoo requested review from mcoker and lboehling August 4, 2025 19:55
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment about layouts since "layout" as a concept are different from "layouts" as a product offering (our grid, gallery, flex, stack, etc layouts), in case that wasn't clear.

- **Control spacers:** Used to set horizontal and vertical padding within controls, like menu toggles and text inputs.
- Control spacer tokens begin with `--pf-t--global--spacer--control--`
- Control spacer tokens begin with `--pf-t--global--spacer--control`
- **Layout spacers:** Used to define spacing with [PatternFly layouts](/layouts/about-layouts).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the layouts we offer, we we pretty much only use gap and gutter spacers. Layouts really only introduce space between elements, not within them (insets are for space inside of something). So if "layout spacers" refers to the layouts listed on https://www.patternfly.org/layouts/about-layouts, then we would remove "inset spacers" from the list and add "gap spacers" if we wanted to be technically correct.

However, if we aren't referring to those specific layouts, and we're using "layout spacers" as a general concept, I think what you have works, except I might still add "gap spacers." IMO I like referring to "layout spacers" this way as a general concept, and not specific to the list of layouts we offer.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - Update spacers guidelines
5 participants