docs(menu): Updates menu guidelines for v6. #4745
Conversation
...documentation-site/patternfly-docs/content/design-guidelines/components/dropdown/dropdown.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Line 70 image (split button with actions). Do we want to show a split button with an icon instead of text since that's mentioned in the text blurb as an option?
There was a problem hiding this comment.
I started trying to make something but I have no clue how icons are meant to be used tbh - that text was already there:
It sounds like it's saying as the menu items, but idk. Does anyone know a practical implementation of this we can convey?
There was a problem hiding this comment.
I can't think of an example where we have an icon in a split on org or figma. Nothing comes to mind for products too so maybe we can remove it?
packages/documentation-site/patternfly-docs/content/design-guidelines/components/menu/menu.md
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/design-guidelines/components/menu/menu.md
Show resolved
Hide resolved
...ges/documentation-site/patternfly-docs/content/design-guidelines/components/select/select.md
Show resolved
Hide resolved
|
Unsure about the split toggle with icon image that I left as a comment, but otherwise addressed everything ty! |
Closes #4647
fyi this pr is longg