-
Notifications
You must be signed in to change notification settings - Fork 368
chore(chart box plot) - convert to typescript #11728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolethoen
merged 8 commits into
patternfly:main
from
Mash707:convert-chart-plot-to-typescript
May 15, 2025
Merged
chore(chart box plot) - convert to typescript #11728
nicolethoen
merged 8 commits into
patternfly:main
from
Mash707:convert-chart-plot-to-typescript
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview: https://patternfly-react-pr-11728.surge.sh A11y report: https://patternfly-react-pr-11728-a11y.surge.sh |
17 tasks
013c96d
to
9b98542
Compare
/* eslint-disable-next-line */ | ||
import chart_color_orange_300 from '@patternfly/react-tokens/dist/esm/chart_color_orange_300'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may just depend on my comment in #11727 (comment), but otherwise this PR looks good
9b98542
to
ecefffb
Compare
thatblindgeye
approved these changes
Apr 29, 2025
nicolethoen
approved these changes
May 15, 2025
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples of ChartArea will be converted to TypeScript: