Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ErrorState): add some customization capabilities #448

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Nov 14, 2024

Closes: #437
Closes: #438

I still want to add the headingLevel enhancement to the other related component groups like UnauthorizedAccess

@nicolethoen nicolethoen requested a review from fhlavac November 14, 2024 16:54
@patternfly-build
Copy link

patternfly-build commented Nov 14, 2024

@dlabaj
Copy link
Collaborator

dlabaj commented Nov 14, 2024

@nicolethoen Looks like there's a linting failure.

@nicolethoen
Copy link
Contributor Author

yeah there are a few more components i'm still planning to update, too. I'll fix them at the same time

@nicolethoen nicolethoen force-pushed the add_rhoai_related_enahncements branch from fa33075 to 824879a Compare November 14, 2024 19:20
@nicolethoen nicolethoen force-pushed the add_rhoai_related_enahncements branch from 824879a to f8b214b Compare November 14, 2024 20:18
Copy link
Collaborator

@fhlavac fhlavac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙂

@nicolethoen nicolethoen requested a review from dlabaj November 15, 2024 15:13
@dlabaj dlabaj merged commit 65f296b into patternfly:main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorState (And related components): expose headingLevel prop ErrorState - add ability to define custom icon
4 participants