Skip to content

Conversation

@IshikaBanga26
Copy link

@IshikaBanga26 IshikaBanga26 commented Aug 6, 2025

📥 Pull Request

Description

This PR introduces a "Favorite Projects" feature that allows users to mark individual project cards as favorites on various category pages (like Static Websites, Responsive Websites, etc.). It also adds a toggle button to filter and view only favorited projects on each page.

The goal of this feature is to improve user experience and navigation by allowing contributors and users to bookmark and revisit their preferred projects easily.

Since some categories like React, Portfolio, and E-commerce do not currently have HTML pages, this PR also suggests updating CONTRIBUTING.md with clear guidelines so future contributors can implement the same favorite functionality consistently when adding new pages.

Fixes # (no open issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
image image

@vercel
Copy link

vercel bot commented Aug 6, 2025

@IshikaBanga26 is attempting to deploy a commit to the pavitraag's projects Team on Vercel.

A member of the Team first needs to authorize it.

@IshikaBanga26
Copy link
Author

Hi @pavitraag ,

I've implemented a reusable "favorite" button feature across the existing project category pages like Static and Responsive Websites. I noticed that there are still some sections listed (like React Applications, Portfolio Sites, and E-commerce) that currently don’t have individual HTML pages, but may be added by future contributors.

To ensure consistency, I’d like to propose a small update to the CONTRIBUTING.md file — specifically a section that explains how new contributors can add the favorite button and toggle functionality when creating those new HTML pages.

This would include:

  • A standard structure for project cards including the favorite button
  • Instructions to include the shared toggle button
  • How to link the shared JS code for favorite handling

Would it be okay if I create a PR suggesting these additions? I just wanted to check with you before editing any shared contribution guidelines.

Thanks for maintaining such a great project!

@pavitraag
Copy link
Owner

@IshikaBanga26 clear the conflicts n u can proceed

@pavitraag
Copy link
Owner

Mention issue number @IshikaBanga26

@pavitraag
Copy link
Owner

@IshikaBanga26 did u raise the issue or not for this pr

@IshikaBanga26
Copy link
Author

I raised an issue #258 for this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants