Skip to content

Conversation

@spacebear21
Copy link
Collaborator

Redis is no longer needed to run the directory service.

Pull Request Checklist

Please confirm the following before requesting review:

Redis is no longer needed to run the directory service.
@spacebear21
Copy link
Collaborator Author

spacebear21 commented Sep 19, 2025

Converting to Draft because I'm not sure whether PJ_STORAGE_DIR needs to be set explicitly? cc @nothingmuch

@spacebear21 spacebear21 marked this pull request as draft September 19, 2025 19:16
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17867660605

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.743%

Totals Coverage Status
Change from base Build 17867308905: 0.01%
Covered Lines: 8559
Relevant Lines: 10100

💛 - Coveralls

@nothingmuch
Copy link
Collaborator

nothingmuch commented Sep 20, 2025

it does, i didn't set a default value because the one for ohttp-keys seemed a bit cavalier just going with something in the current directory

we could figure out if we want to use xdg directories (not sure that's advised for a service) or maybe /var/lib/payjoin-directory or /var/run/payjoin-directory, but i think my preferred approach is to require it to be set seems safest

@spacebear21
Copy link
Collaborator Author

This change also requires an up-to-date docker image for payjoin-directory so marking this as blocked until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants