fix(richtext-lexical): allow to indent children even if their parents are not indentable #12042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
approved these changes
Apr 8, 2025
auto-merge was automatically disabled
April 15, 2025 11:37
Head branch was pushed to by a user without write access
tak-amboss
force-pushed
the
fix-allow-indenting-children
branch
from
9301439 to
700a8e1
Compare
|
🚀 This is included in version v3.35.0 |
GermanJablo
pushed a commit
that referenced
this pull request
Apr 23, 2025
…lected node allows it (#12182) ### What? Enables the indent/outdent button if at least one selected node can be indented/outdented. ### Why? Before, the buttons were disabled e.g. if multiple nodes were selected of which one was not indentable/outdentable or if a child node was not indentable but the parent was, leading to inconsistent behavior. ### How? Checks if the node itself or any parent fulfills the criteria. The change affects only the buttons active state, not the actual indentation logic. Fixes #12042
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
… are not indentable (#12042) ### What? Allows to indent children in richtext-lexical if the parent of that child is not indentable. Changes the behavior introduced in #11739 ### Why? If there is a document structure with e.g. `tableNode > list > listItem` and indentation of `tableNode` is disabled, it should still be possible to indent the list items. ### How? Disable the indent button only if indentation of one of the selected nodes itself is disabled.
kendelljoseph
pushed a commit
that referenced
this pull request
May 15, 2025
…lected node allows it (#12182) ### What? Enables the indent/outdent button if at least one selected node can be indented/outdented. ### Why? Before, the buttons were disabled e.g. if multiple nodes were selected of which one was not indentable/outdentable or if a child node was not indentable but the parent was, leading to inconsistent behavior. ### How? Checks if the node itself or any parent fulfills the criteria. The change affects only the buttons active state, not the actual indentation logic. Fixes #12042
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
… are not indentable (#12042) ### What? Allows to indent children in richtext-lexical if the parent of that child is not indentable. Changes the behavior introduced in #11739 ### Why? If there is a document structure with e.g. `tableNode > list > listItem` and indentation of `tableNode` is disabled, it should still be possible to indent the list items. ### How? Disable the indent button only if indentation of one of the selected nodes itself is disabled.
kendelljoseph
pushed a commit
that referenced
this pull request
May 19, 2025
…lected node allows it (#12182) ### What? Enables the indent/outdent button if at least one selected node can be indented/outdented. ### Why? Before, the buttons were disabled e.g. if multiple nodes were selected of which one was not indentable/outdentable or if a child node was not indentable but the parent was, leading to inconsistent behavior. ### How? Checks if the node itself or any parent fulfills the criteria. The change affects only the buttons active state, not the actual indentation logic. Fixes #12042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows to indent children in richtext-lexical if the parent of that child is not indentable. Changes the behavior introduced in #11739
Why?
If there is a document structure with e.g.
tableNode > list > listItemand indentation oftableNodeis disabled, it should still be possible to indent the list items.How?
Disable the indent button only if indentation of one of the selected nodes itself is disabled.