This repository was archived by the owner on May 29, 2025. It is now read-only.
Custom http request executor with async support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a property that can be overriden to specify an async executor, as with httpx or a custom "request-like" method invoking aiohttp or any other async http client. Mantains API and will not break current installations, if this library should work with the (defunct, not supported and past-EOL) or with python versions prior to 3.5, this PR would require a few small tweaks: - Using generator-based coroutines (altough is currently being deprecated by python and won't be supported on 3.10). - Added an IF upon asyncio import
Fixed a small typo, and getattr not raising an AttributeError when it should
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a property that can be overriden to specify an async executor,
as with httpx or a custom "request-like" method invoking aiohttp or any
other async http client.
Mantains API and will not break current installations, if this library
should work with the (defunct, not supported and past-EOL) or with
python versions prior to 3.5, this PR would require a few small tweaks:
deprecated by python and won't be supported on 3.10).
Note: I've not added any tests because I'm unsure about adding an async http library as a dependency.