Improve the error message when collecting restart files.#708
Improve the error message when collecting restart files.#708Qian-HuiChen wants to merge 2 commits intopayu-org:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 63.70% 63.72% +0.02%
==========================================
Files 67 67
Lines 5554 5555 +1
==========================================
+ Hits 3538 3540 +2
+ Misses 2016 2015 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@manodeep @anton-seaice thanks for raising the issue! |
anton-seaice
left a comment
There was a problem hiding this comment.
Looks good - could you add a test in
https://github.com/ACCESS-NRI/payu/blob/705-om3-errormsg/test/models/access-om3/test_access_om3.py
payu/models/cesm_cmeps.py
Outdated
| Possible cause: model runtime is shorter than the restart write frequency. | ||
| Fix: | ||
| 1. Remove the incomplete restart subdirectory in the archive path | ||
| 2. Adjust the restart write frequency to be shorter than/equal to the model runtime.""" |
There was a problem hiding this comment.
| 2. Adjust the restart write frequency to be shorter than/equal to the model runtime.""" | |
| 2. Adjust the restart write frequency to write a restart at the end of the model run.""" |
There was a problem hiding this comment.
Sounds good. Unit test is added to confirm error message is delivered when
- rpointer file is missing
- restart files in pointer are missing
Make the FileNotFound error message clearer when collecting restart files.
Closes #705.
Ref issue in OM3 config repo.