#3221 fix: hypothetically leaking carriage return characters in headi…

…ngs in note link dialog under Windows

Signed-off-by: Patrizio Bekerle <[email protected]>

CHANGELOG.md

@@ -3,6 +3,8 @@
 ## 25.2.0
 - Added GDScript support to the note edit code block syntax highlighter
   (for [#3222](https://github.com/pbek/QOwnNotes/issues/3222), thank you, @DarienMC)
+- Try to fix hypothetically leaking carriage return characters in the headings in
+  the note link dialog under Windows (for [#3221](https://github.com/pbek/QOwnNotes/issues/3221))
 
 ## 25.1.7
 - When inserting an image or attachment file via their insert dialogs or via

src/dialogs/linkdialog.cpp

@@ -110,9 +110,10 @@ Note LinkDialog::getSelectedNote() const {
 }
 
 QString LinkDialog::getSelectedHeading() const {
+    // Trim the heading text, in case there are trailing carriage return characters leaking in Windows
     return ui->headingListWidget->selectedItems().isEmpty()
                ? ""
-               : ui->headingListWidget->currentItem()->text();
+               : ui->headingListWidget->currentItem()->text().trimmed();
 }
 
 QString LinkDialog::getURL() const {

src/entities/note.cpp

@@ -4265,7 +4265,8 @@ QStringList Note::getHeadingList() {
 
     while (i.hasNext()) {
         QRegularExpressionMatch match = i.next();
-        headingList << match.captured(1);
+        // Trim the heading text, in case there are trailing carriage return characters leaking in Windows
+        headingList << match.captured(1).trimmed();
     }
 
     return headingList;