#3130 fix: small graphical glitch under macOS in Markdown highlightin…

…g settings Signed-off-by: Patrizio Bekerle <[email protected]>
pbek · Oct 13, 2024 · 66e030c · 66e030c
1 parent 3f35a77
commit 66e030c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 32 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # QOwnNotes Changelog
 
+## 24.10.2
+- A small graphical glitch on macOS in the *Markdown highlighting settings* was fixed
+  (for [#3130](https://github.com/pbek/QOwnNotes/issues/3130))
+
 ## 24.10.1
 - In the *Stored image files* and the *Stored attachments* dialogs it's now possible
   to only show files of the current note (for [#2354](https://github.com/pbek/QOwnNotes/issues/2354))

diff --git a/src/dialogs/settingsdialog.cpp b/src/dialogs/settingsdialog.cpp
@@ -3848,7 +3848,7 @@ void SettingsDialog::on_resetMessageBoxesButton_clicked() {
 }
 
 void SettingsDialog::on_markdownHighlightingCheckBox_toggled(bool checked) {
-    ui->markdownHighlightingFrame->setEnabled(checked);
+    ui->fullyHighlightedBlockquotesCheckBox->setEnabled(checked);
 }
 
 void SettingsDialog::on_localTrashEnabledCheckBox_toggled(bool checked) {

diff --git a/src/dialogs/settingsdialog.ui b/src/dialogs/settingsdialog.ui
@@ -5401,6 +5401,13 @@ li.checked::marker { content: &quot;\2612&quot;; }
                 <string>Markdown highlighting</string>
                </property>
                <layout class="QGridLayout" name="gridLayout_35">
+                <item row="1" column="1">
+                 <widget class="QCheckBox" name="fullyHighlightedBlockquotesCheckBox">
+                  <property name="text">
+                   <string>Fully highlight blockquotes</string>
+                  </property>
+                 </widget>
+                </item>
                 <item row="0" column="1" colspan="2">
                  <widget class="QCheckBox" name="markdownHighlightingCheckBox">
                   <property name="toolTip">
@@ -5411,37 +5418,6 @@ li.checked::marker { content: &quot;\2612&quot;; }
                   </property>
                  </widget>
                 </item>
-                <item row="1" column="1" colspan="2">
-                 <widget class="QFrame" name="markdownHighlightingFrame">
-                  <property name="frameShape">
-                   <enum>QFrame::Shape::NoFrame</enum>
-                  </property>
-                  <property name="frameShadow">
-                   <enum>QFrame::Shadow::Raised</enum>
-                  </property>
-                  <layout class="QVBoxLayout" name="verticalLayout_22">
-                   <property name="leftMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="topMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="rightMargin">
-                    <number>0</number>
-                   </property>
-                   <property name="bottomMargin">
-                    <number>0</number>
-                   </property>
-                   <item>
-                    <widget class="QCheckBox" name="fullyHighlightedBlockquotesCheckBox">
-                     <property name="text">
-                      <string>Fully highlight blockquotes</string>
-                     </property>
-                    </widget>
-                   </item>
-                  </layout>
-                 </widget>
-                </item>
                </layout>
               </widget>
              </item>