Skip to content

fix: make build process clear#20

Merged
Xuanwo merged 2 commits intopcwalton:mainfrom
devillove084:fix/build_warning
Aug 3, 2025
Merged

fix: make build process clear#20
Xuanwo merged 2 commits intopcwalton:mainfrom
devillove084:fix/build_warning

Conversation

@devillove084
Copy link
Contributor

@devillove084 devillove084 commented Aug 3, 2025

@Xuanwo , Fixed some issues under C++20 compilation and reduced some buzz messages generated during async compilation.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 3, 2025

Mostly LGTM, please resolve the conflicts. Thank you!

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks nice!

@devillove084
Copy link
Contributor Author

@pcwalton It looks like you still need to click the merge button. In the future, would it be possible to grant owner-level permissions to either me or @Xuanwo ?

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 3, 2025

@pcwalton It looks like you still need to click the merge button. In the future, would it be possible to grant owner-level permissions to either me or @Xuanwo ?

Hey, please don't ping pcwalton. I'm waiting for the CI to pass.

@Xuanwo Xuanwo merged commit 56629c3 into pcwalton:main Aug 3, 2025
3 checks passed
@devillove084
Copy link
Contributor Author

@pcwalton It looks like you still need to click the merge button. In the future, would it be possible to grant owner-level permissions to either me or @Xuanwo ?

Hey, please don't ping pcwalton. I'm waiting for the CI to pass.

Got it. I'm sorry—I wasn't aware of this issue. I'll make sure not to repeat this mistake going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants