Fix wrong function from abs to fabsf

[tpadioleau]

In C, abs is only for integers, I think you should be using fabs instead.

List of things to check before making a PR

Before merging your code, please check the following:

• you have added a line describing your changes to the Changelog;
• you have added unit tests for any new or improved feature;
• In case you updated dependencies, you have checked pdi/docs/CheckList.md
• you have checked your code format:
  • you have checked that you respect all conventions specified in CONTRIBUTING.md;
  • you have checked that the indentation and formatting conforms to the .clang-format;
  • you have documented with doxygen any new or changed function / class;
• you have correctly updated the copyright headers:
  • your institution is in the copyright header of every file you (substantially) modified;
  • you have checked that the end-year of the copyright there is the current one;
• you have updated the AUTHORS file:
  • you have added yourself to the AUTHORS file;
  • if this is a new contribution, you have added it to the AUTHORS file;
• you have added everything to the user documentation:
  • any new CMake configuration option;
  • any change in the yaml config;
  • any change to the public or plugin API;
  • any other new or changed user-facing feature;
  • any change to the dependencies;
• you have correctly linked your MR to one or more issues:
  • your MR solves an identified issue;
  • your commit contain the Fix #issue keyword to autoclose the issue when merged.

[benoitmartin88]

Thanks for the contribution.
I think it would good opportunity to also update the tests for doubles. The asserts for doubles should probably also be tested using fabs.

[benoitmartin88]

Nice, thanks !
I just looked at the test case for doubles, would you mind also adding a test using fabs ?

[tpadioleau]

What tolerance do you want ?

[benoitmartin88]

I guess something similar to what is done for floats. 0.000001f ?

[jbigot]

as a reminder, we have a bug, assert shouldn't be used in tests, it will only trigger if tests are compiled in debug mode.

Maybe switching to gtest everywhere could be a solution

[tpadioleau]

I let you open an issue about updating the tests then ? I feel it becomes out of scope of the current PR which is about fixing a warning from the Apple Clang compiler.

[jbigot]

Clearly a separate issue already identified on its own right. I was just mentioning this as we advise to use assert. We shouldn't :)

[benoitmartin88]

Same as other file.