Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Friends’ Schedules Not Displaying Due to Map Feature in PCP #711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamesdoh0109
Copy link
Contributor

Description:
The recent addition of the map feature in PCP introduced a bug where users were unable to view their friends’ schedules. This issue affected the rendering logic, preventing schedules from being properly displayed. The issue primarily stemmed from the course colors (colors used to display course blocks/map pins) not being properly assigned to friends' courses, and also not distinguishing between a friend's schedule and the current user's schedule when displaying the map for the "active" schedule.

This PR includes a fix that:

  • Assigns colors to a selected friend's courses upon retrieval
  • Adding a check in the map component to be able to display the active schedule correctly (whether it is the current user's schedule or a friend's)

Screenshots:
Screenshot 2025-03-15 at 9 32 56 PM
Screenshot 2025-03-15 at 9 33 03 PM

@el-agua
Copy link
Contributor

el-agua commented Mar 16, 2025

Backend changes seem fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Penn Course Plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants