-
Notifications
You must be signed in to change notification settings - Fork 4
PCSM-207 Documented a PLM_MONGODB_CLI_OPERATION_TIMEOUT env var #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR documents a new environment variable PLM_MONGODB_CLI_OPERATION_TIMEOUT that controls the timeout duration for MongoDB client operations.
- Added documentation for the
PLM_MONGODB_CLI_OPERATION_TIMEOUTenvironment variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/install/parameters.md
Outdated
| | `PLM_CLONE_NUM_PARALLEL_COLLECTIONS` | Number of collections cloned in parallel | `2` | | ||
| | `PLM_CLONE_NUM_READ_WORKERS` | Number of read workers for cloning | `NumCPU / 4` | | ||
| | `PLM_CLONE_NUM_INSERT_WORKERS` | Number of insert workers for cloning | `NumCPU * 4` | | ||
| | `PLM_MONGODB_CLI_OPERATION_TIMEOUT` | The time to wait for the MongoDB client operation such as insert, update, delete | `5m` | |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The description could be clearer by specifying what happens when this timeout is reached (e.g., 'Maximum time to wait before timing out MongoDB client operations').
| | `PLM_MONGODB_CLI_OPERATION_TIMEOUT` | The time to wait for the MongoDB client operation such as insert, update, delete | `5m` | | |
| | `PLM_MONGODB_CLI_OPERATION_TIMEOUT` | Maximum time to wait before timing out MongoDB client operations (such as insert, update, delete). If the timeout is reached, the operation will fail. | `5m` | |
modified: docs/install/parameters.md
cbe3530 to
a584629
Compare
docs/install/parameters.md
Outdated
| | `PLM_CLONE_NUM_PARALLEL_COLLECTIONS` | Number of collections cloned in parallel | `2` | | ||
| | `PLM_CLONE_NUM_READ_WORKERS` | Number of read workers for cloning | `NumCPU / 4` | | ||
| | `PLM_CLONE_NUM_INSERT_WORKERS` | Number of insert workers for cloning | `NumCPU * 4` | | ||
| | `PLM_MONGODB_CLI_OPERATION_TIMEOUT` | Maximum time to wait before timing out MongoDB client operations such as insert, update, delete. If the timeout is reached, the operation will fail. | `5m` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we can go with this name, but we could also go with updated PCSM_* prefix and maybe also change the rest of env var names. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rebase and proceed with renaming this new one
|
Closing as the changes are already in main |
modified: docs/install/parameters.md