Skip to content

Conversation

@nastena1606
Copy link
Collaborator

modified: docs/install/usage.md
modified: docs/plm-commands.md

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the behavior when both include and exclude filters are specified for namespace replication in PLM. It clarifies that exclude filters take precedence over include filters when both are used together.

Key Changes:

  • Added documentation explaining filter precedence behavior when both include and exclude flags are used
  • Provided a concrete example showing how db1.users would be excluded even when db1.* is included

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/plm-commands.md Added detailed explanation and example of filter precedence to the --exclude-namespaces flag description
docs/install/usage.md Added general explanation of filter precedence behavior in the usage documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| -----| -----------|
| `--include-namespaces` | Replicate only the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited|
| `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited|
| `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited. <br> When both `--include-namespaces` and `--exclude-namespaces` flags are specified, the exclude filters take precedence. For example, if the `--include-namespaces` includes `db1.*` and ``--exclude-namespaces` has `db1.users`, PLM syncs all collections of`db1` **except** `db1.users`.|
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after 'of' in 'ofdb1'. Should be 'of db1'.

Copilot uses AI. Check for mistakes.
| -----| -----------|
| `--include-namespaces` | Replicate only the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited|
| `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited|
| `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited. <br> When both `--include-namespaces` and `--exclude-namespaces` flags are specified, the exclude filters take precedence. For example, if the `--include-namespaces` includes `db1.*` and ``--exclude-namespaces` has `db1.users`, PLM syncs all collections of`db1` **except** `db1.users`.|
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double backtick before '--exclude-namespaces'. Should be single backtick.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@inelpandzic inelpandzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering using PLM instead of PCSM is on purpose since you're gonna rename everything later in one go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants