-
Notifications
You must be signed in to change notification settings - Fork 2
PCSM-230 Documented the use of include and exclude filters for the same db #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR documents the behavior when both include and exclude filters are specified for namespace replication in PLM. It clarifies that exclude filters take precedence over include filters when both are used together.
Key Changes:
- Added documentation explaining filter precedence behavior when both include and exclude flags are used
- Provided a concrete example showing how
db1.userswould be excluded even whendb1.*is included
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/plm-commands.md | Added detailed explanation and example of filter precedence to the --exclude-namespaces flag description |
| docs/install/usage.md | Added general explanation of filter precedence behavior in the usage documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/plm-commands.md
Outdated
| | -----| -----------| | ||
| | `--include-namespaces` | Replicate only the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited| | ||
| | `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited| | ||
| | `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited. <br> When both `--include-namespaces` and `--exclude-namespaces` flags are specified, the exclude filters take precedence. For example, if the `--include-namespaces` includes `db1.*` and ``--exclude-namespaces` has `db1.users`, PLM syncs all collections of`db1` **except** `db1.users`.| |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after 'of' in 'ofdb1'. Should be 'of db1'.
docs/plm-commands.md
Outdated
| | -----| -----------| | ||
| | `--include-namespaces` | Replicate only the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited| | ||
| | `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited| | ||
| | `--exclude-namespaces` | Replicate everything except the specified namespaces. Multiple namespaces are supported as a comma separated list. The number of namespaces to specify is unlimited. <br> When both `--include-namespaces` and `--exclude-namespaces` flags are specified, the exclude filters take precedence. For example, if the `--include-namespaces` includes `db1.*` and ``--exclude-namespaces` has `db1.users`, PLM syncs all collections of`db1` **except** `db1.users`.| |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double backtick before '--exclude-namespaces'. Should be single backtick.
inelpandzic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering using PLM instead of PCSM is on purpose since you're gonna rename everything later in one go?
modified: docs/install/usage.md
modified: docs/plm-commands.md