Skip to content

Conversation

catalinaadam
Copy link
Contributor

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

For OpenShift deployments, you'll also need:

- OpenShift Container Platform 4.15. Other versions will likely work but they haven't been tested
- Administrative access for `SecurityContextConstraints` (SCC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it's a requirement

Comment on lines 79 to 111
```bash
# Create custom SCC for PMM
cat <<EOF | oc create -f -
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
metadata:
name: pmm-scc
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
allowHostPID: false
allowHostPorts: false
allowPrivilegedContainer: false
fsGroup:
type: RunAsAny
runAsUser:
type: MustRunAsNonRoot
seLinuxContext:
type: MustRunAs
supplementalGroups:
type: RunAsAny
volumes:
- configMap
- downwardAPI
- emptyDir
- persistentVolumeClaim
- projected
- secret
EOF
# Grant the SCC to the PMM service account
oc adm policy add-scc-to-user pmm-scc -z pmm-sa -n <your-namespace>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really need custom SCC

Comment on lines 151 to 153
secret:
create: false
name: pmm-secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious where this came from

Comment on lines 223 to 234
10. (OpenShift only) Ensure adequate resources:
```yaml
resources:
requests:
memory: "2Gi"
cpu: "1000m"
limits:
memory: "4Gi"
cpu: "2000m"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's the case

Nailya
Nailya previously requested changes Sep 3, 2025
### OpenShift-specific requirements
For OpenShift deployments, you'll also need:

- OpenShift Container Platform 4.15. Other versions will likely work but they haven't been tested
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested starting from 4.16


- [Helm v3](https://docs.helm.sh/using_helm/#installing-helm)
- Kubernetes cluster running a [supported version](https://kubernetes.io/releases/version-skew-policy/#supported-versions) and [Supported Helm](https://helm.sh/docs/topics/version_skew/) versions
- Storage driver with snapshot support (for backups)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous line "Supported Helm" probaly should be "supported Helm"

@ademidoff ademidoff temporarily deployed to Documentation_PMM-14132 - pmm-doc-3 PR #4452 September 4, 2025 11:46 — with Render Destroyed
…ptions/helm/index.md

Co-authored-by: Nurlan Moldomurov <[email protected]>
@ademidoff ademidoff temporarily deployed to Documentation_PMM-14132 - pmm-doc-3 PR #4452 September 4, 2025 11:48 — with Render Destroyed
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving PR, but we need another look of @nogueiraanderson

@BupycHuk BupycHuk changed the base branch from v3 to pmm-3.4.0 September 5, 2025 11:14
@catalinaadam catalinaadam requested a review from Nailya September 5, 2025 14:08
@catalinaadam catalinaadam removed the request for review from Nailya September 15, 2025 13:50
@catalinaadam catalinaadam dismissed Nailya’s stale review September 15, 2025 13:50

implemented feedback

@catalinaadam catalinaadam requested a review from Nailya September 15, 2025 13:52
Base automatically changed from pmm-3.4.0 to v3-doc-prod September 15, 2025 15:45
@ademidoff ademidoff temporarily deployed to Documentation_PMM-14132 - pmm-doc-3 PR #4452 September 16, 2025 07:49 — with Render Destroyed
@ademidoff ademidoff temporarily deployed to Documentation_PMM-14132 - v3-doc-prod PR #4452 September 16, 2025 07:49 — with Render Destroyed
@catalinaadam catalinaadam merged commit 6187bb0 into v3-doc-prod Sep 16, 2025
4 of 5 checks passed
@catalinaadam catalinaadam deleted the Documentation_PMM-14132 branch September 16, 2025 07:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://percona-pmm.readme.io/v3/reference/release-notes-3-4-0 Status: 404

For technical details about API enhancements, see the [API Release Notes](https://percona-pmm.readme.io/v3/reference/release-notes-3-4-0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants