Skip to content

Conversation

@igroene
Copy link
Member

@igroene igroene commented Sep 5, 2025

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@igroene igroene requested a review from a team as a code owner September 5, 2025 18:04
@igroene igroene requested review from BupycHuk and idoqo and removed request for a team September 5, 2025 18:04
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.98%. Comparing base (7319476) to head (d4b160c).
⚠️ Report is 141 commits behind head on v3.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #4490   +/-   ##
=======================================
  Coverage   44.98%   44.98%           
=======================================
  Files         356      356           
  Lines       44808    44808           
=======================================
  Hits        20157    20157           
  Misses      22998    22998           
  Partials     1653     1653           
Flag Coverage Δ
managed 44.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@idoqo idoqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igroene can you also leave some context to why they're now uneeded?

@igroene
Copy link
Member Author

igroene commented Sep 8, 2025

The point is we should ship built-in alerts that are actually useful for the majority of users.
The first one is comparing memory used by mongo connections vs total server memory. That might be useful for some edge case but it can be determined by looking at dashboards, there is no need to have an alert.
The second one is about mongo consuming most of system memory. On a dedicated server, it is expected that mongo will consume most of the memory, so no point in having an alert for that.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2025

CLA assistant check
All committers have signed the CLA.

@idoqo
Copy link
Contributor

idoqo commented Oct 27, 2025

Hi @igroene , i'm closing this since we removed the files while moving the templates over (based on your OG pull request): fa7bd51

@idoqo idoqo closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants