PMM-14442 Fix the data race #4786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #4786 +/- ##
==========================================
+ Coverage 45.68% 45.73% +0.05%
==========================================
Files 364 364
Lines 37759 37752 -7
==========================================
+ Hits 17249 17265 +16
+ Misses 18851 18831 -20
+ Partials 1659 1656 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
force-pushed
the
PMM-14442-fix-the-race
branch
from
729ccb6 to
15b6ad0
Compare
ademidoff
force-pushed
the
PMM-14442-fix-the-race
branch
from
dde6ba7 to
fb0d8c8
Compare
ademidoff
commented
Nov 28, 2025
| }() | ||
|
|
||
| args := []string{"-dryRun", "-promscrape.config", f.Name()} | ||
| args := []string{"-promscrape.config.dryRun=true", "-promscrape.config", f.Name()} |
Member
Author
There was a problem hiding this comment.
The syntax changed in this version.
ademidoff
requested review from
JiriCtvrtka and
idoqo
and removed request for
a team
ademidoff
force-pushed
the
PMM-14442-fix-the-race
branch
from
a1ae299 to
c1f2e45
Compare
Contributor
|
Great job, seems I am not able to hit it anymore and crash PMM server down. I will create ticket about go routines without reacting on context in rest of PMM repo. |
JiriCtvrtka
approved these changes
Dec 1, 2025
idoqo
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14442
Link to the Feature Build: SUBMODULES-4132
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: