Skip to content

Conversation

shahidullah79
Copy link
Collaborator

This PR adds recovery test cases to the pg_tde test suite.
The tests were copied from PostgreSQL’s src/test/recovery/ directory.
Updated to work with pg_tde by:

  • Initializing the server with pg_tde.
  • Adding both global and local encryption keys.
  • Setting the default table access method to tde_heap.
  • Enabling WAL encryption by default (can be disabled with WAL_ENCRYPTION=off).

@shahidullah79
Copy link
Collaborator Author

014_unlogged_reinit.pl
018_wal_optimize.pl

These two test cases failing even wal_encryption is 'off'. These issues already reported.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.08%. Comparing base (b2bb77c) to head (6da9b35).
⚠️ Report is 8 commits behind head on TDE_REL_17_STABLE.

❌ Your project status has failed because the head coverage (82.08%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #528      +/-   ##
=====================================================
- Coverage              82.19%   82.08%   -0.12%     
=====================================================
  Files                     25       25              
  Lines                   3174     3171       -3     
  Branches                 515      506       -9     
=====================================================
- Hits                    2609     2603       -6     
- Misses                   456      460       +4     
+ Partials                 109      108       -1     
Components Coverage Δ
access 83.42% <ø> (-0.05%) ⬇️
catalog 87.60% <ø> (ø)
common 77.77% <ø> (ø)
encryption 72.97% <ø> (ø)
keyring 73.21% <ø> (ø)
src 94.15% <ø> (ø)
smgr 95.93% <ø> (+0.63%) ⬆️
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndersAstrand
Copy link
Collaborator

We are fairly sure we want to go with #535 instead of this, but your work here helped a lot in understanding what was needed for us to run the tests with wal encryption. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants