Addition of pcp2openmetrics tool #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natoscott
reviewed
Feb 9, 2024
lmchilton
force-pushed
the
pcp2openmetrics
branch
from
2b98db4 to
95d85fd
Compare
lmchilton
force-pushed
the
pcp2openmetrics
branch
from
95d85fd to
dec074c
Compare
natoscott
requested changes
Feb 28, 2024
There was a problem hiding this comment.
@lmchilton there's a few QA issues lurking still:
- the output in test 1131.out is not filtered (most labels)m
- 1827.out contains unfiltered domainname label value,
- not sure what "+Metric hinv.ncpu details (last fetch: 1707935533):" is? but it looks at least unfiltered, possibly just a debug diagnostic?
- maybe update the header comment in qa/1131 also to say it tests both pcp2json and pcp2openmetrics now
pcp2openmetrics.1 has some incorrect dates in the copyright notice as well.
Otherwise looking good I think.
lmchilton
force-pushed
the
pcp2openmetrics
branch
from
dec074c to
6f41451
Compare
natoscott
approved these changes
Feb 29, 2024
…rmat including three sets of revisions made from initial PR for pcp2openmetrics tool. Made several changes to qa tests to filter output.
lmchilton
force-pushed
the
pcp2openmetrics
branch
from
6f41451 to
7c9a49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tool pcp2openmetrics to support conversion of pcp metrics to open metric format.
Updated relevant QA tests to test basic functionality of tool as well as HTTP transfer function.
Updated pcp2json QA test 1589 to use a pythonserver instead of nc to test HTTP functionality.