feat: allow runner_pool to override runner type for self-hosted pools#767
Closed
atheurer wants to merge 1 commit intoperftool-incubator:masterfrom
Closed
feat: allow runner_pool to override runner type for self-hosted pools#767atheurer wants to merge 1 commit intoperftool-incubator:masterfrom
atheurer wants to merge 1 commit intoperftool-incubator:masterfrom
Conversation
When runner_pool is specified, scenarios configured with type "github" will now run on self-hosted runners with the specified pool label. This enables workflows to redirect GitHub-hosted jobs to self-hosted runner pools while maintaining backward compatibility. Changes: - Modify build_runner_labels() to check runner_pool first - If runner_pool is set, use self-hosted with pool label regardless of runner_type - Pass scenario tags when runner_pool is specified, even for "github" type - Maintain backward compatibility: no runner_pool = existing behavior Backward compatibility verified: - No runner_pool argument → uses ubuntu-latest for "github" type (unchanged) - runner_pool specified → uses self-hosted with pool (new behavior) - self-hosted without pool → uses self-hosted with tags (unchanged) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atheurer
force-pushed
the
backport-runner-pool-2026.1
branch
from
2d914cd to
d96c653
Compare
k-rister
requested changes
Mar 17, 2026
Contributor
k-rister
left a comment
k-rister
left a comment
There was a problem hiding this comment.
needs to be pushed upstream for PR
Contributor
Author
|
Closing to recreate with upstream branch as head instead of fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows workflows to redirect GitHub-hosted jobs (
type: "github") to self-hosted runner pools when therunner_poolparameter is specified, while maintaining full backward compatibility.Changes
build_runner_labels()to checkrunner_poolparameter firstrunner_poolis set, use self-hosted runners with pool label regardless ofrunner_typerunner_poolis specified, even for "github" type scenariosBackward Compatibility
✅ No
runner_poolargument → usesubuntu-latestfor "github" type (unchanged)✅ With
runner_pool→ usesself-hosted+ pool label (new behavior)✅
self-hostedwithout pool → usesself-hostedwith tags (unchanged)Example Behavior
Before (or without runner_pool):
After (with runner_pool):
Use Case
This enables CI workflows to:
type: "github"Testing
CI tests will verify backward compatibility - existing workflows without
runner_poolcontinue to work unchanged.Related to runner pool support added in #753