Skip to content

feat: allow runner_pool to override runner type for self-hosted pools#772

Merged
k-rister merged 1 commit into2025.2from
2025.2-updates
Mar 20, 2026
Merged

feat: allow runner_pool to override runner type for self-hosted pools#772
k-rister merged 1 commit into2025.2from
2025.2-updates

Conversation

@k-rister
Copy link
Contributor

When runner_pool is specified, scenarios configured with type "github" will now run on self-hosted runners with the specified pool label. This enables workflows to redirect GitHub-hosted jobs to self-hosted runner pools while maintaining backward compatibility.

Changes:

  • Modify build_runner_labels() to check runner_pool first
  • If runner_pool is set, use self-hosted with pool label regardless of runner_type
  • Pass scenario tags when runner_pool is specified, even for "github" type
  • Maintain backward compatibility: no runner_pool = existing behavior

Backward compatibility verified:

  • No runner_pool argument → uses ubuntu-latest for "github" type (unchanged)
  • runner_pool specified → uses self-hosted with pool (new behavior)
  • self-hosted without pool → uses self-hosted with tags (unchanged)

When runner_pool is specified, scenarios configured with type "github"
will now run on self-hosted runners with the specified pool label.
This enables workflows to redirect GitHub-hosted jobs to self-hosted
runner pools while maintaining backward compatibility.

Changes:
- Modify build_runner_labels() to check runner_pool first
- If runner_pool is set, use self-hosted with pool label regardless of runner_type
- Pass scenario tags when runner_pool is specified, even for "github" type
- Maintain backward compatibility: no runner_pool = existing behavior

Backward compatibility verified:
- No runner_pool argument → uses ubuntu-latest for "github" type (unchanged)
- runner_pool specified → uses self-hosted with pool (new behavior)
- self-hosted without pool → uses self-hosted with tags (unchanged)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister merged commit a4a3196 into 2025.2 Mar 20, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Crucible Tracking Mar 20, 2026
@k-rister k-rister deleted the 2025.2-updates branch March 20, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants