Skip to content

feat: allow runner_pool to override runner type for self-hosted pools#775

Merged
k-rister merged 2 commits into2026.1from
2026.1-updates
Mar 20, 2026
Merged

feat: allow runner_pool to override runner type for self-hosted pools#775
k-rister merged 2 commits into2026.1from
2026.1-updates

Conversation

@k-rister
Copy link
Contributor

When runner_pool is specified, scenarios configured with type "github" will now run on self-hosted runners with the specified pool label. This enables workflows to redirect GitHub-hosted jobs to self-hosted runner pools while maintaining backward compatibility.

Changes:

  • Modify build_runner_labels() to check runner_pool first
  • If runner_pool is set, use self-hosted with pool label regardless of runner_type
  • Pass scenario tags when runner_pool is specified, even for "github" type
  • Maintain backward compatibility: no runner_pool = existing behavior

Backward compatibility verified:

  • No runner_pool argument → uses ubuntu-latest for "github" type (unchanged)
  • runner_pool specified → uses self-hosted with pool (new behavior)
  • self-hosted without pool → uses self-hosted with tags (unchanged)

When runner_pool is specified, scenarios configured with type "github"
will now run on self-hosted runners with the specified pool label.
This enables workflows to redirect GitHub-hosted jobs to self-hosted
runner pools while maintaining backward compatibility.

Changes:
- Modify build_runner_labels() to check runner_pool first
- If runner_pool is set, use self-hosted with pool label regardless of runner_type
- Pass scenario tags when runner_pool is specified, even for "github" type
- Maintain backward compatibility: no runner_pool = existing behavior

Backward compatibility verified:
- No runner_pool argument → uses ubuntu-latest for "github" type (unchanged)
- runner_pool specified → uses self-hosted with pool (new behavior)
- self-hosted without pool → uses self-hosted with tags (unchanged)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add detection for K3s control-plane nodes using the
node-role.kubernetes.io/control-plane label. K3s single-node
clusters are treated the same as microk8s, with the node
counted as both master and worker.

This enables the kube endpoint to work with K3s distributions,
resolving "No masters found" and "No workers found" errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@k-rister k-rister merged commit 439bc71 into 2026.1 Mar 20, 2026
@k-rister k-rister deleted the 2026.1-updates branch March 20, 2026 13:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Crucible Tracking Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants