Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the perl versions currently supported by travis #14

Closed
wants to merge 1 commit into from

Conversation

markusbeth
Copy link
Contributor

No description provided.

@pali
Copy link
Member

pali commented Jan 9, 2020

Alternative .travis.yml file which does not remove support for testing older Perl versions which are still supported by DBD::ODBC:

before_install:
 - sudo apt-get update
 - sudo apt-get install -qq unixodbc unixodbc-dev
 - sudo apt-get install -qq libsqliteodbc
 - if [ -z "$PERLBREW_PERL" ]; then eval $(curl https://travis-perl.github.io/init) --auto; fi
env:
 global:
   - DBI_DSN=dbi:ODBC:DRIVER=SQLite3
 matrix:
   - DBD_ODBC_UNICODE=1
   - 
language: perl
perl:
  - "5.8"
  - "5.10"
  - "5.12"
  - "5.14"
  - "5.16"
  - "5.18"
  - "5.20"
  - "5.22"
  - "5.22-shrplib"
  - "5.24"
  - "5.24-shrplib"
  - "5.26"
  - "5.26-shrplib"
  - "5.28"
  - "5.30"
notifications:
  email:
    recipents:
      - [email protected]
    on_success: always
    on_failure: always
  irc:
    channels:
      - "irc.perl.org#dbi"
    on_success: change
    on_failure: always

If official travis does not support particular Perl version then script fallbacks to use Perl from unofficial (but better) travis-perl project.

I suggest to do not drop testing of old Perl versions which are still usable with DBD::ODBC.

@pali
Copy link
Member

pali commented Jan 21, 2020

@markusbeth Any reason why not to test old perl versions?

@markusbeth
Copy link
Contributor Author

There is absolutely no reason to not test old perl versions as long as the tests work as expected. When I opened PR #13 travis told me that almost all tests failed. But the tests do not fail due to my changes but because the configured perl version could not be installed. As I did not know about the travis-perl project the only (or simplest) solution in my eyes was to adapt the perl versions to test to those officially provided by travis.
If the alternative .travis.yml file from @pali also makes the tests to succeed (even for the old perl versions) I would be happy to see this in the repository.

@markusbeth markusbeth closed this Jan 22, 2020
@pali
Copy link
Member

pali commented Jan 30, 2020

I created PR #16 with my above approach.

@mjegh
Copy link
Member

mjegh commented Jan 30, 2020

Does your approach @pali work as I've not seen a successful run through. I'm happy to merge it if it works.

@pali
Copy link
Member

pali commented Jan 30, 2020

@mjegh currently it is failing on error:

Press return to continue...  

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

And message Press return to continue... comes from Makefile.PL, line 212:

DBD-ODBC/Makefile.PL

Lines 201 to 213 in 336fe97

EOT
if ($OSNAME ne 'MSWin32') {
print <<'EOT';
You should also be aware that on non-Windows platforms ODBC drivers come
in two forms, thread-safe and non-thread-safe drivers and you may need
to make sure you are using the right one.
EOT
}
# see rt 46944 for why the following was suggested to be commented
# out which I rejected as PERL_MM_USE_DEFAULT can be used
prompt("Press return to continue...");
}

Is there a way how to avoid waiting for return key which on Travis obviously cannot be pressed?

@mjegh
Copy link
Member

mjegh commented Jan 30, 2020

Is there something set in Travis the script can check for so we don't prompt on Travis.

@pali
Copy link
Member

pali commented Jan 30, 2020

Now I'm looking at that PERL_MM_USE_DEFAULT comment. Seems that this could be a key to avoiding asking for prompt.

@mjegh
Copy link
Member

mjegh commented Jan 30, 2020

In general you can detect if you are on Travis-CI by checking the environment variables. You can check either for CI=true or the more specific TRAVIS=true

@pali
Copy link
Member

pali commented Jan 30, 2020

Setting PERL_MM_USE_DEFAULT=1 helped. Now there is no waiting for pressing key. And tests passed in that PR #16 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants