Add Internationalization, New Language Translations, and Create new appInfo Bottom Sheet as IOS #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces string resources to internationalize the following screens:
- Onboarding:
- BatteryOptimizationScreen
- BluetoothCheckScreen
- InitializingScreen
- LocationCheckScreen
- PermissionExplanationScreen
- UI:
- ChatHeader
- DialogComponents
- InputComponents
* Add Belarusian, Georgian, Kazakh, Russian, Turkish, and Ukrainian translations Warning: this translation was created using AI, so there may be inaccuracies in the translation.
This commit introduces string resources to internationalize the following screens:
- Onboarding:
- BatteryOptimizationScreen
- BluetoothCheckScreen
- InitializingScreen
- LocationCheckScreen
- PermissionExplanationScreen
- UI:
- ChatHeader
- DialogComponents
- InputComponents
* Add Belarusian, Georgian, Kazakh, Russian, Turkish, and Ukrainian translations Warning: this translation was created using AI, so there may be inaccuracies in the translation.
yet300
changed the title
This commit adds new string resources for the app info screen in English, Belarusian, Georgian, Kazakh, Russian, Turkish, and Ukrainian. The new strings include: - App tagline - Features section with titles and descriptions for offline communication, end-to-end encryption, extended range, favorites, mutual favorites, and mentions. - Privacy section with titles and descriptions for no tracking, ephemeral identity, and panic mode. - "How to use" section with instructions. - Warning message about private message security. - "Done" button text. The Ukrainian strings file was also moved from `app/src/main/res/uk/strings.xml` to `app/src/main/res/values-uk/strings.xml` to follow standard Android resource directory naming.
- Replaced AppInfoDialog with AppInfoBottomSheet(IOS like). - Created `BottomSheetComponents.kt` to house the new `AppInfoBottomSheet` and its related composables. - Updated `ChatScreen.kt` to use `AppInfoBottomSheet` and invoke it from a new composable `ChatSheets`. - Removed `AppInfoDialog` from `DialogComponents.kt`. - `AppInfoBottomSheet` now displays app features, privacy information, usage instructions, and a warning message in a scrollable list. - Added a top bar to the bottom sheet that becomes opaque on scroll and includes a "Done" button.
…vements # Conflicts: # app/src/main/java/com/bitchat/android/onboarding/BluetoothCheckScreen.kt # app/src/main/java/com/bitchat/android/ui/DialogComponents.kt # app/src/main/java/com/bitchat/android/ui/InputComponents.kt # app/src/main/res/values-be/strings.xml # app/src/main/res/values-ka/strings.xml # app/src/main/res/values-kk/strings.xml # app/src/main/res/values-ru/strings.xml # app/src/main/res/values-tr/strings.xml # app/src/main/res/values/strings.xml
yet300
changed the title
Contributor
Author
|
|
|
Good |
Collaborator
|
Thanks for the PR, @yet300 the build is failing. |
- Add "mention" string to default and localized strings.xml files - Remove `app/src/main/res/uk/strings.xml` as it is a duplicate of `app/src/main/res/values-uk/strings.xml`
* Use stringResource for message hint * Minor code cleanup in InputComponents.kt * Add stringResource import in DialogComponents.kt
Contributor
Author
should work now) |
|
I am a native speaker of Belarusian and Russian. I looked through the translations and found no mistakes, except for some strings. <string name="battery_optimization_skip">Прапусціць зараз</string>;should be corrected to <string name="setup_not_complete">Налада не завершана</string>;should be corrected to <string name="app_info_tagline">mesh-чат для групавога абмену паведамленнямі</string>;should be corrected to <string name="feature_mutual_favorites_desc">пішыце адзін аднаму праз nostr, калі вы за зонай дзеяння mesh-сеткі</string>;should be corrected <string name="feature_mentions_desc">выкарыстоўвайце @nickname для згадвання канкрэтных людзей</string>;Russian: should be corrected to <string name="battery_optimization_skip">Пропустить сейчас</string>;should be corrected to <string name="feature_mentions_desc">используйте @nickname для упоминания конкретных людей</string>
|
Contributor
Author
|
Oh thanks, I'll change it |
1 similar comment
Contributor
Author
|
Oh thanks, I'll change it |
This commit introduces per-app language preferences by: - Adding a `locales_config.xml` file defining supported locales: en, ru, uk, be, tr, kk, ka, ar, cs, it, az, bqi, iw. - Updating `AndroidManifest.xml` to reference the `locales_config.xml` via the `android:localeConfig` attribute in the `<application>` tag. - Incrementing `tools:targetApi` from 31 to 33 in `AndroidManifest.xml`.
Contributor
Author
|
open new pr(#275) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
##Supported Languages
AI - translate with AI
Native - verified by a native speaker
Checklist