fix(commands): fix /clear, /msg, and /join behavior in geochats #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FINALLY. i couldn't even use bitchat because channels didn't work, I don't want public chats. |
|
please review this @callebtc |
|
@callebtc we need this bux fix🙏🏼 |
|
4.1 fix? @callebtc |
|
i wonder why this hasn't been looked into? this is honestly a security fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core issue was that the
CommandProcessordid not handle GeoHash channel contexts properly, leading to missing message or state synchronization.This PR ensures consistent command behavior between Mesh and GeoHash chats.
Closes: #422
Relates to: #450