Skip to content

Conversation

@callebtc
Copy link
Collaborator

Description

Checklist

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +160 to +164
locationManager.requestLocationUpdates(
provider,
2000L,
5f,
continuousLocationListener

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Repeated beginLiveRefresh piles up location listeners

The new real-time refresh registers continuous updates every time beginLiveRefresh is called, but unlike the previous timer-based implementation it never removes an existing listener before calling requestLocationUpdates. In LocationChannelsSheet the LaunchedEffect keyed on availableChannels and bookmarks re-invokes beginLiveRefresh on each channel update while the sheet stays open, so every location result triggers another registration to the same continuousLocationListener. This stacks multiple active listeners, causing duplicate callbacks and unnecessary background location polling (battery and compute overhead) until the sheet is dismissed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants