Skip to content

Conversation

@callebtc
Copy link
Collaborator

Description

Checklist

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +598 to +602
val cb = object : ConnectivityManager.NetworkCallback() {
override fun onAvailable(network: Network) {
cm.bindProcessToNetwork(network)
try {
val client = ss.accept().apply { keepAlive = true }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid binding process to Wi‑Fi Aware network

When acting as the Wi‑Fi Aware server, onAvailable calls cm.bindProcessToNetwork(network). This sets the process‑wide default network to the peer’s Aware link, so while a connection is active all outbound traffic (e.g., Nostr relay connections or HTTP calls) will be forced over a local, non‑routable network until the session drops. The client path explicitly avoids process binding, so this likely isn’t intended. Consider binding only the server socket (e.g., via network.bindSocket or the network’s socket factory) instead of switching the entire app to the Aware network.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants