-
Notifications
You must be signed in to change notification settings - Fork 622
QR and Verification feature #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # app/src/main/assets/nostr_relays.csv
# Conflicts: # app/src/main/assets/nostr_relays.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| val icon = when { | ||
| isVerified -> Icons.Filled.Verified | ||
| sessionState == "handshaking" -> Icons.Outlined.Sync | ||
| sessionState == "failed" -> Icons.Outlined.OutlinedWarning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unresolved OutlinedWarning icon reference
SecurityVerificationSheet won’t compile: the buildStatusInfo branch for failed sessions references Icons.Outlined.OutlinedWarning, but the only available symbol is the aliased OutlinedWarning/Icons.Outlined.Warning. With the current name, the code does not resolve and the module fails to build, blocking the new verification UI.
Useful? React with 👍 / 👎.
|
very nice! |
|
I have reviewed the implementation and applied the following improvements for robustness and code quality: Refactoring & Code Quality
Security & Concurrency
These changes make the feature production-ready and stable. |
|
Build errors fixed:
The app now builds successfully. |
Summary
Changes
Video
FILE.2025-12-31.20.24.30.mp4
Notes
app/src/main/java/com/bitchat/android/MainActivity.ktandapp/src/main/AndroidManifest.xml.Checklist