Skip to content

Conversation

@callebtc
Copy link
Collaborator

@callebtc callebtc commented Jan 4, 2026

Reverts #532

@callebtc callebtc merged commit 123a24c into main Jan 4, 2026
1 check passed
@callebtc callebtc deleted the revert-532-fix/small-screen-header-519 branch January 4, 2026 14:08
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c62502a509

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

colors = TopAppBarDefaults.topAppBarColors(
containerColor = Color.Transparent
),
modifier = Modifier.height(headerHeight) // Ensure compact header height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow the header to expand for large font scales

Fixing the header height to 42.dp with Modifier.height(headerHeight) forces the TopAppBar to stay at that exact size even when users increase system font size or when the title needs multiple lines (e.g., long channel names). In those cases the text and icons will be measured taller than 42.dp and get clipped because the container cannot grow, which is an accessibility regression compared to the previous heightIn(min = headerHeight) behavior. Consider using a minimum height instead of a fixed height so the bar can expand when the content requires it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants