Refactor MessageRouter to use generic Transport abstraction #902
Conversation
- Decouple MessageRouter from specific Mesh/Nostr implementations - Update NostrTransport to implement isPeerReachable using a local cache of favorited peers - Update ChatViewModel to inject transports as a list - Mark NostrTransport as @unchecked Sendable to handle internal thread safety
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let transport = transports.first(where: { $0.isPeerReachable(peerID) }) { | ||
| SecureLogger.debug("Outbox -> \(type(of: transport)) for \(peerID.id.prefix(8))… id=\(messageID.prefix(8))…", category: .session) | ||
| transport.sendPrivateMessage(content, to: peerID, recipientNickname: nickname, messageID: messageID) | ||
| } else { | ||
| // Keep unsent items queued | ||
| remaining.append((content, nickname, messageID)) | ||
| } |
There was a problem hiding this comment.
MessageRouter now delivers queued messages only when a transport reports reachability (transports.first(where: { $0.isPeerReachable(peerID) })). However NostrTransport.isPeerReachable is fed from the asynchronously warmed reachablePeers cache (see NostrTransport.swift:43-52), and flushAllOutbox() is invoked during ChatViewModel initialization (ChatViewModel.swift:518) before that cache is populated. At launch, favorites that are Nostr-reachable therefore appear unreachable, leaving queued messages in outbox indefinitely until another event (mesh reconnect or another favorite toggle) retriggers a flush. Users sending immediately after startup to an existing favorite over Nostr will see those messages stuck.
Useful? React with 👍 / 👎.
|
🫂 :-) |
2 participants
This PR refactors the MessageRouter to decouple it from specific transport implementations (BLE/Nostr).
Changes:
Verification: