perf: optimize MessageDeduplicator performance #912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2025 14:50
allowBluetoothHFP is not available on iOS Simulator, causing build failures. Use conditional compilation to exclude this option when building for simulator while keeping it for device builds.
- Make Entry struct Equatable for better testability - Remove down to 75% of maxCount instead of fixed 100 items for better amortization of cleanup cost - Reuse Date instance to reduce allocations in isDuplicate() - Add documentation comments for public methods - Improve memory capacity management in cleanup()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #472
Performance and memory optimizations for
MessageDeduplicator:Changes:
EntrystructEquatablefor better testabilitymaxCountinstead of fixed 100 items, improving amortization of cleanup costDateinstance inisDuplicate()to reduce allocationscleanup()- only shrink when array is significantly oversized AND count is lowBenefits:
Test plan