-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash script for --stdin
test.
#33
Conversation
Warning Rate Limit Exceeded@huacnlee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 15 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update simplifies and enhances testing procedures for a project. It streamlines the workflow by removing a redundant testing job in favor of a more comprehensive one that includes a make command. Additionally, it introduces a shell script for specialized stdin testing, ensuring that formatting functions as expected. This change not only refines the test suite but also broadens its capabilities to include more nuanced test scenarios. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/test.yml (1 hunks)
- Makefile (1 hunks)
- tests/stdin_test.sh (1 hunks)
Additional comments not posted (3)
Makefile (1)
4-4
: Ensure the newly added scripttests/stdin_test.sh
is properly integrated and functions as expected within the project's testing framework.tests/stdin_test.sh (1)
18-18
: Verify the correctness of the test case, especially the expected output, to ensure it aligns with the intended functionality ofpestfmt --stdin
..github/workflows/test.yml (1)
28-28
: Ensure that the modified workflow correctly executes all necessary tests and integrates seamlessly with the project's continuous integration process.
3c58a79
to
b5c60d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .github/workflows/test.yml (1 hunks)
- Makefile (1 hunks)
- src/main.rs (1 hunks)
- tests/cli_test.sh (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test.yml
Additional comments not posted (1)
Makefile (1)
3-3
: Ensure the scriptcli_test.sh
exists and is executable. Consider renaming it tostdin_test.sh
to match the PR objectives and improve clarity.Verification successful
The script
cli_test.sh
has been confirmed to exist and is executable. The suggestion to rename the script for clarity should be considered based on the PR's objectives, which requires further context not available here.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the script exists and is executable if [ ! -x "tests/cli_test.sh" ]; then echo "The script tests/cli_test.sh does not exist or is not executable." exit 1 else echo "The script tests/cli_test.sh exists and is executable." fiLength of output: 153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
4b62ade
to
5074efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .github/workflows/test.yml (1 hunks)
- Makefile (1 hunks)
- src/main.rs (1 hunks)
- tests/cli_test.sh (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- .github/workflows/test.yml
- Makefile
- src/main.rs
- tests/cli_test.sh
f345655
to
48abfd7
Compare
48abfd7
to
1da735f
Compare
tests/cli_test.sh
for unit test cli command.--stdin
not do format not formating from stdin #31Test example:
Summary by CodeRabbit