Skip to content

Add: ChatBubble and test #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GraphiteSprite
Copy link
Contributor

Added ChatBubble based on example at https://flowbite.com/docs/components/chat-bubble/ minus dropdown menu. Awaiting feedback.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR integrates a new ChatBubble component into PetalComponents with varied styles and includes tests for each variant.

  • Added comprehensive ChatBubble variants in /lib/petal_components/chat_bubble.ex based on the kind attribute.
  • Integrated ChatBubble into the public API via updates in /lib/petal_components.ex.
  • Introduced tests in /test/petal/chat_bubble_test.exs that cover all variants by checking common container classes.
  • Noted potential maintenance challenges due to repetitive markup and inconsistent tooltip implementations.

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nhobes
Copy link
Contributor

nhobes commented Apr 16, 2025

Thanks for this! I think you may still need to push up the css for the default.css file?

@GraphiteSprite
Copy link
Contributor Author

Ah! I missed that part 🙏 Will review 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants