Disable webmentions for non-production environments#595
Draft
Disable webmentions for non-production environments#595
Conversation
Add an additional empty check after mb_convert_encoding() to prevent a ValueError when loadHTML() receives an empty string in PHP 8.1+. Fixes #332
When WP_ENVIRONMENT_TYPE is 'local', 'development', or 'staging', webmention sending, receiving, and discovery are disabled. Production and unset environments remain unaffected. Adds a `webmention_disable_for_environment` filter so developers can override this behavior. Fixes #588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WP_ENVIRONMENT_TYPEislocal,development, orstagingproduction)webmention_disable_for_environmentfilter that receives the disable boolean and the environment type string, allowing developers to overrideTest plan
WP_ENVIRONMENT_TYPEtolocaland verify no webmentions are sent or received, and discovery headers are absentWP_ENVIRONMENT_TYPEtoproduction(or leave unset) and verify webmentions work normallywebmention_disable_for_environmentfilter to override the default behavior (e.g., force-enable on staging)Fixes #588