Bump Go, dependencies, Actions #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Go version, updates package dependencies, and modernizes GitHub Actions and CRD annotations.
- Updates controller-runtime configuration in main.go to use the new metrics server options.
- Adopts context-aware list functions in controllers and improves test stability with eventual assertions.
- Upgrades GitHub Actions workflows to use the latest versions and updates CRD controller-gen annotations.
Reviewed Changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Migrates metrics configuration to use server.Options |
| controllers/suite_test.go | Replaces direct Update calls with Eventually for improved stability |
| controllers/noderemediationtemplate_controller.go | Uses context-aware nodeMapFn for listing templates |
| controllers/noderemediation_controller.go | Adopts context-aware map function and streamlines Watch syntax |
| config/rbac/role.yaml | Refactors RBAC rules, adding new pods/eviction permissions and cleanup |
| config/crd/bases/*.yaml | Updates controller-gen versions and refines description formatting |
| api/v1alpha1/zz_generated.deepcopy.go | Removes legacy build tag in favor of the new build constraint |
| .github/workflows/*.yaml | Upgrades Actions steps with newer versions |
Files not reviewed (3)
- Dockerfile: Language not supported
- Makefile: Language not supported
- go.mod: Language not supported
y1r
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
I attempted to re-scaffold the entire project using newer kubebuilder, but the tests do not pass with the new codebase, and I could not solve that in some hours
Thank you for trying re-scaffolding! Updating dependencies is enough for now. Thank you for sending PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Go version, Go package dependencies, tools, and GitHub Actions.
Actually I attempted to re-scaffold the entire project using newer kubebuilder, but the tests do not pass with the new codebase, and I could not solve that in some hours 😢