Skip to content

Fix issue with updates to server group names not triggering tree sort #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KijongHan
Copy link
Contributor

Resolves issue #8015

What does this PR do?

This PR resolves issue in the object explorer window for server groups, where updating the names for existing server groups don't trigger a reordering of the tree structure.

I initially tried using the inotify method with WatchEvent.Moved and WatchEvent.Changed events, passing in parameters for the updated node path for the Moved event and the parent directory "/browser" for the Changed event but neither triggers the rerender - as a workaround removing and adding the node using the existing fileTreeHandle recreates the node and places it in the appropriate sort order

@KijongHan
Copy link
Contributor Author

hi @akshay-joshi - could you please look into reapproving the workflows? rebased from upstream

@KijongHan KijongHan changed the title Fix issue with updates to server group names not triggering tree sort #8015 Fix issue with updates to server group names not triggering tree sort Mar 15, 2025
@KijongHan KijongHan changed the title #8015 Fix issue with updates to server group names not triggering tree sort Fix issue with updates to server group names not triggering tree sort Mar 15, 2025
Copy link
Contributor

@khushboovashi khushboovashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this patch, the browser window gets blank if I update the server group name.
Please take a look at the console logs.

Screenshot 2025-03-17 at 10 34 05 AM

@KijongHan
Copy link
Contributor Author

With this patch, the browser window gets blank if I update the server group name. Please take a look at the console logs.

Screenshot 2025-03-17 at 10 34 05 AM

thanks for testing the PR @khushboovashi - which browser did you use to test the changes? While I have encountered other issues with these changes, I wasn't able to reproduce these errors with updating server groups

@KijongHan
Copy link
Contributor Author

I've encountered a few other issues testing these changes - updating any child nodes (anything under server groups) results in the nodes being placed in the root directory node (the /browser) as opposed to being under the appropriate parent (for example, updating the server name results in the node being placed under the server group directory

@khushboovashi
Copy link
Contributor

With this patch, the browser window gets blank if I update the server group name. Please take a look at the console logs.
Screenshot 2025-03-17 at 10 34 05 AM

thanks for testing the PR @khushboovashi - which browser did you use to test the changes? While I have encountered other issues with these changes, I wasn't able to reproduce these errors with updating server groups

I am using Google Chrome v 134.0

@khushboovashi
Copy link
Contributor

I've encountered a few other issues testing these changes - updating any child nodes (anything under server groups) results in the nodes being placed in the root directory node (the /browser) as opposed to being under the appropriate parent (for example, updating the server name results in the node being placed under the server group directory

I am not facing such issues. Which browser are you using? Have you tested the same thing on the released version?

@KijongHan
Copy link
Contributor Author

With this patch, the browser window gets blank if I update the server group name. Please take a look at the console logs.
Screenshot 2025-03-17 at 10 34 05 AM

thanks for testing the PR @khushboovashi - which browser did you use to test the changes? While I have encountered other issues with these changes, I wasn't able to reproduce these errors with updating server groups

I am using Google Chrome v 134.0

Thanks for those details @khushboovashi - I managed to reproduce that same issue

I've encountered a few other issues testing these changes - updating any child nodes (anything under server groups) results in the nodes being placed in the root directory node (the /browser) as opposed to being under the appropriate parent (for example, updating the server name results in the node being placed under the server group directory

I am not facing such issues. Which browser are you using? Have you tested the same thing on the released version?

yeap the release version is working as expected (although it looks like editing tables to be under different schemas is predictably keeping the table node under the previous schema, as the file tree is not being refreshed) - it was as a byproduct of the changes in this PR

@khushboovashi
Copy link
Contributor

Hi @KijongHan, are you planning to work on the reported issue, or should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants