-
Notifications
You must be signed in to change notification settings - Fork 728
Fix issue with updates to server group names not triggering tree sort #8547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ering of tree - fix spelling error in comment
hi @akshay-joshi - could you please look into reapproving the workflows? rebased from upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for testing the PR @khushboovashi - which browser did you use to test the changes? While I have encountered other issues with these changes, I wasn't able to reproduce these errors with updating server groups |
I've encountered a few other issues testing these changes - updating any child nodes (anything under server groups) results in the nodes being placed in the root directory node (the |
I am using Google Chrome v 134.0 |
I am not facing such issues. Which browser are you using? Have you tested the same thing on the released version? |
Thanks for those details @khushboovashi - I managed to reproduce that same issue
yeap the release version is working as expected (although it looks like editing tables to be under different schemas is predictably keeping the table node under the previous schema, as the file tree is not being refreshed) - it was as a byproduct of the changes in this PR |
Hi @KijongHan, are you planning to work on the reported issue, or should I close this PR? |
Resolves issue #8015
What does this PR do?
This PR resolves issue in the object explorer window for server groups, where updating the names for existing server groups don't trigger a reordering of the tree structure.
I initially tried using the
inotify
method withWatchEvent.Moved
andWatchEvent.Changed
events, passing in parameters for the updated node path for theMoved
event and the parent directory"/browser"
for theChanged
event but neither triggers the rerender - as a workaround removing and adding the node using the existingfileTreeHandle
recreates the node and places it in the appropriate sort order