Fix meta try primitive #968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
commented
May 13, 2025
Comment on lines
+980
to
+984
| savedTempOop2 := tempOop2. | ||
| tempOop2 := self stackValue: 3. "actual receiver" | ||
| rcvr := self stackValue: 2. "receiver for primitive" | ||
| (objectMemory isOopForwarded: rcvr) ifTrue: [ | ||
| rcvr := objectMemory followForwarded: rcvr ]. |
There was a problem hiding this comment.
As a nice side effect, fixing the indexes here (0 based) "fixes" the following test in Pharo:
MirrorPrimitivesTest >> testExecutingPrimitive
| actual |
<expectedFailure> "it will be supported by VM at some point"
actual := MirrorPrimitives withReceiver: 100 tryPrimitive: 1 withArguments: #(2).
self assert: actual equals: 102
guillep
commented
May 13, 2025
| self pop: 4; push: rcvr] "use first arg as receiver" | ||
| ifFalse: | ||
| [self pop: 2]. | ||
| ifTrue: [ "use first arg as receiver""...and receiver if the three arg form" |
There was a problem hiding this comment.
This first comment got moved by the reformatting, I'll put it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Debugging the follign code (Cmd+Shift+D)
And stepping into
tryPrimitive:withArgs:crashes the VM.Cause
This happens because the primitive stores intermediate data in special vm variables (tempOop and tempOop2) that are remapped in case a GC passes and later restored if the called primitive fails.
In this case, the call to primitive 118 is reentrant: primitive 118 calls primitive 118.
And this causes the lose of the tempOop and tempOop2 values of the first call.
TODOs after this PR
basicNewet al