Skip to content
This repository was archived by the owner on Jan 7, 2022. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
5fb35d5
Simplify pom.xml files
Sep 11, 2021
da7f7cc
Revert resource filtering
Sep 11, 2021
c5259e1
Use `slf4j-simple` for logging in tests
Sep 11, 2021
e643cc3
Change `groupId`s, add `validator-jsonschema` module, update POMs
Sep 13, 2021
3a6957e
Outline validation protocol, reorganize packages, implement JSONschem…
Sep 13, 2021
c1fefde
Remove `json-schema-validator` from `validator-core`
Sep 13, 2021
35ea811
Merge pull request #11 from ielis/validator_apis
pnrobinson Sep 14, 2021
b639292
testing refactor
pnrobinson Sep 15, 2021
808fe37
datagen for testing
pnrobinson Sep 16, 2021
045c258
adding 'type' error type
pnrobinson Sep 17, 2021
3a8b168
adding tests for disease element
pnrobinson Sep 17, 2021
1602ee1
Clean up commented code
Sep 17, 2021
0af3b87
Merge pull request #19 from ielis/testing_refactor
pnrobinson Sep 22, 2021
fd220ad
Merge pull request #16 from phenopackets/testing_refactor
pnrobinson Sep 22, 2021
4de85ca
correcting params
pnrobinson Sep 22, 2021
b4176cd
fix JSON schema for vitalStatus
pnrobinson Sep 22, 2021
7d51403
fix JSON schema for timeElement
pnrobinson Sep 22, 2021
89e64bf
fixed disease-stage definition
pnrobinson Sep 26, 2021
52b6c5e
prototype cli app
pnrobinson Sep 26, 2021
7a13c78
prototype OntologyValidator
pnrobinson Sep 26, 2021
0cf1996
refactor ValidationInfoType
pnrobinson Sep 27, 2021
f964880
cleanup
pnrobinson Sep 27, 2021
75d3fb6
Work on `validator-ontology`
Sep 30, 2021
a7d8f0f
Use Java 16, simplify POMs, add description
Sep 30, 2021
563dd15
Remove redundant POM lines
Sep 30, 2021
a45e1b4
Simplify and standardize JSONschema validator.
Sep 30, 2021
fb8c52c
Refactor HpoValidatorTest
Sep 30, 2021
d7e4722
Merge pull request #21 from ielis/finish-refactor
pnrobinson Oct 4, 2021
458f973
Merge pull request #20 from phenopackets/finish-refactor
pnrobinson Oct 4, 2021
c42b7c7
update to use phenotools for creating examples for testing.
pnrobinson Oct 7, 2021
089d289
fixed bug (disease requires at least one ontology class (term)
pnrobinson Oct 8, 2021
7217939
adding definitions for measurement
pnrobinson Oct 8, 2021
d18cbe4
adding tests for measurement (Value)
pnrobinson Oct 8, 2021
7327e42
fixed JSON Schema for Value (Measurement)
pnrobinson Oct 8, 2021
6297fdf
fixed JSON Schema for ComplexValue (Measurement)
pnrobinson Oct 8, 2021
3dece6b
ComplexValue (Measurement) tests
pnrobinson Oct 8, 2021
127a851
fixed definition of Evidence
pnrobinson Oct 9, 2021
7e56aec
new unit tests
pnrobinson Oct 9, 2021
377d2eb
Merge pull request #22 from phenopackets/measurementJSONschema
pnrobinson Oct 11, 2021
ddb774f
biosample validation
pnrobinson Oct 11, 2021
f244cae
refactoring
pnrobinson Oct 11, 2021
15e3f18
updating for new phenopacket-tools API
pnrobinson Oct 11, 2021
9eda567
refactor to use JSON string
pnrobinson Oct 11, 2021
3c288fb
Merge pull request #23 from phenopackets/refactor2
pnrobinson Oct 11, 2021
1ac487f
Merge pull request #24 from phenopackets/measurementJSONschema
pnrobinson Oct 11, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,4 @@ nb-configuration.xml
.nb-gradle/

# Created by .ignore support plugin (hsz.mobi)
/phenopacket-validation.tsv
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,8 @@ Library and tools to help validate phenopackets
This app uses version 2.0.0 (branch v2) of [phenopacket-schema](https://github.com/phenopackets/phenopacket-schema).
To build this app, clone phenopacket-schema and ``mvn install`` the ``v2`` branch locally. The you should be
able to build and run this app with standard maven/java. Note the app requires Java 11 or higher.

It also uses version 0.0.1-SNAPSHOT of [phenopacket-tools](https://github.com/phenopackets/phenopacket-tools)
to create the test cases. It also needs to be install locally using maven.

We plan to put all requirements into maven central shortly to simplify the build.
Empty file modified mvnw
100644 → 100755
Empty file.
92 changes: 69 additions & 23 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,19 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>org.phenopackets.phenopacket-schema</groupId>
<groupId>org.phenopackets.validator</groupId>
<artifactId>validator</artifactId>
<version>0.1.1-SNAPSHOT</version>

<packaging>pom</packaging>
<name>Phenopacket validator</name>
<description>Library and tools to help validate phenopackets</description>

<modules>
<module>validator-core</module>
<module>validator-cli</module>
<module>validator-jsonschema</module>
<module>validator-ontology</module>
</modules>

<parent>
Expand Down Expand Up @@ -60,7 +64,12 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>11</java.version>
<java.version>16</java.version>

<phenol.version>1.6.3</phenol.version>
<protobuf.version>3.14.0</protobuf.version>
<phenopacket-schema.version>2.0.0</phenopacket-schema.version>

<junit.jupiter.version>5.7.1</junit.jupiter.version>
</properties>

Expand All @@ -83,39 +92,76 @@
</plugins>
</build>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol-core</artifactId>
<version>${phenol.version}</version>
</dependency>
<dependency>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol-io</artifactId>
<version>${phenol.version}</version>
</dependency>
<dependency>
<groupId>org.phenopackets</groupId>
<artifactId>phenopacket-schema</artifactId>
<version>${phenopacket-schema.version}</version>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
<version>${protobuf.version}</version>
<exclusions>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>com.networknt</groupId>
<artifactId>json-schema-validator</artifactId>
<version>1.0.42</version>
</dependency>

<!-- TEST DEPENDENCIES -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>3.12.4</version>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<!-- logging -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<!-- TEST DEPENDENCIES -->
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
<!-- TEST DEPENDENCIES -->
<!--<dependency>-->
<!--<groupId>org.springframework.boot</groupId>-->
<!--<artifactId>spring-boot-starter-test</artifactId>-->
<!--<scope>test</scope>-->
<!--</dependency>-->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>${junit.jupiter.version}</version>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.jupiter.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<scope>test</scope>
</dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
</project>
40 changes: 9 additions & 31 deletions validator-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,58 +5,36 @@
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.phenopackets.phenopacket-schema</groupId>
<groupId>org.phenopackets.validator</groupId>
<artifactId>validator</artifactId>
<version>0.1.1-SNAPSHOT</version>
</parent>

<artifactId>validator-cli</artifactId>
<version>0.1.1-SNAPSHOT</version>
<packaging>jar</packaging>

<name>validator-cli</name>
<description>Command-line utility for validating phenopackets</description>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>
</properties>

<dependencies>
<dependency>
<groupId>org.phenopackets.phenopacket-schema</groupId>
<artifactId>validator-core</artifactId>
<groupId>org.phenopackets.validator</groupId>
<artifactId>validator-jsonschema</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-autoconfigure</artifactId>
<groupId>org.phenopackets.validator</groupId>
<artifactId>validator-ontology</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol-io</artifactId>
</dependency>
<dependency>
<groupId>info.picocli</groupId>
<artifactId>picocli-spring-boot-starter</artifactId>
<artifactId>picocli</artifactId>
<version>4.6.1</version>
</dependency>
</dependencies>

<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
</resource>
</resources>
<plugins>
<plugin>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
</plugin>
</plugins>
</build>

</project>

This file was deleted.

This file was deleted.

This file was deleted.

Loading