Skip to content

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Feb 2, 2026

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates the C++ development container to use Clang 20 and the latest version of Include What You Use. The main changes are focused on upgrading toolchain versions to ensure compatibility with the latest features and improvements.

Toolchain upgrades:

  • Updated the Clang toolchain from version 19 to version 20 throughout the development container configuration, including all related tools and dependencies in .devcontainer/cpp/apt-requirements-clang.json.
  • Updated the default CLANG_VERSION argument in .devcontainer/cpp/Dockerfile from 19 to 20.

Other dependency updates:

  • Bumped the INCLUDE_WHAT_YOU_USE_VERSION argument in .devcontainer/cpp/Dockerfile from 0.23 to 0.24.
  • Updated the mull mutation testing tool from version 0.27.1 (for Clang 19) to 0.29.0 (for Clang 20) in .devcontainer/cpp/apt-requirements-clang.json.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner February 2, 2026 16:19
Copilot AI review requested due to automatic review settings February 2, 2026 16:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the C++ development container's LLVM/Clang toolchain from version 19 to version 20, along with associated dependencies to maintain compatibility with the new major version.

Changes:

  • Upgraded Clang toolchain and all related LLVM tools from version 19 to 20
  • Updated Include What You Use from version 0.23 to 0.24
  • Updated Mull mutation testing tool from 0.27.1 to 0.29.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.devcontainer/cpp/apt-requirements-clang.json Updated all Clang/LLVM package versions from 19 to 20, including new version numbers and updated Mull to 0.29.0
.devcontainer/cpp/Dockerfile Changed default CLANG_VERSION from 19 to 20 and INCLUDE_WHAT_YOU_USE_VERSION from 0.23 to 0.24

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1125

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 167.84 MB 167.84 MB 34 B (0%) 🔽
linux/arm64 160.6 MB 160.6 MB +104 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.55s
✅ DOCKERFILE hadolint 3 0 0 0.71s
✅ GHERKIN gherkin-lint 6 0 0 2.4s
✅ JSON npm-package-json-lint yes no no 0.47s
✅ JSON prettier 21 4 0 0 0.56s
✅ JSON v8r 21 0 0 7.58s
✅ MARKDOWN markdownlint 12 0 0 0 0.97s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.23s
✅ REPOSITORY checkov yes no no 17.64s
✅ REPOSITORY gitleaks yes no no 0.52s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 28.6s
✅ REPOSITORY secretlint yes no no 0.89s
✅ REPOSITORY syft yes no no 1.86s
✅ REPOSITORY trivy yes no no 7.18s
✅ REPOSITORY trivy-sbom yes no no 0.22s
✅ REPOSITORY trufflehog yes no no 2.2s
⚠️ SPELL lychee 80 1 0 21.73s
✅ YAML prettier 28 0 0 0 0.99s
✅ YAML v8r 28 0 0 8.13s
✅ YAML yamllint 28 0 0 0.78s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx [email protected] --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1125

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 548.25 MB 548.25 MB 47 B (0%) 🔽
linux/arm64 502.73 MB 502.73 MB +103 B (+0%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1125

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 682.84 MB 689.54 MB +6.7 MB (+0.98%) 🔼
linux/arm64 664.57 MB 670.64 MB +6.07 MB (+0.91%) 🔼

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Test Results

 7 files  ±0   7 suites  ±0   3m 53s ⏱️ -9s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
69 runs  ±0  69 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 08bf143. ± Comparison against base commit f69df6d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants