Skip to content

fix: update devcontainer template structure#1132

Merged
rjaegers merged 4 commits intomainfrom
fix/update-devcontainer-templates-structure
Feb 4, 2026
Merged

fix: update devcontainer template structure#1132
rjaegers merged 4 commits intomainfrom
fix/update-devcontainer-templates-structure

Conversation

@rjaegers
Copy link
Member

@rjaegers rjaegers commented Feb 3, 2026

🚀 Hey, I have created a Pull Request

Description of changes

This pull request refactors the workflow for publishing devcontainer templates and standardizes the organization and naming of template files. The main changes include moving and updating workflow configuration, renaming and updating template metadata, and making minor configuration tweaks.

Workflow refactoring and configuration:

  • The publish-devcontainer-templates job in .github/workflows/release-build.yml now uses a reusable workflow (wc-publish-templates.yml), simplifying the main workflow file and centralizing the template publishing logic.
  • Added a new reusable workflow file .github/workflows/wc-publish-templates.yml that defines the steps for publishing devcontainer templates, supporting both manual and workflow calls.

Template file renaming and metadata standardization:

  • Renamed and updated devcontainer-template.json files for both C++ and Rust templates to use simplified IDs and names (cpp and rust), and formatted the JSON for consistency. [1] [2]
  • Renamed .github/dependabot.yml files for both templates to new locations under templates/, and updated the cooldown.default-days value from 5 to 7 for both C++ and Rust templates.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner February 3, 2026 13:56
Copilot AI review requested due to automatic review settings February 3, 2026 13:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the devcontainer template publishing workflow and standardizes template metadata across C++ and Rust flavors. The changes extract template publishing logic into a reusable workflow and simplify template identifiers and formatting.

Changes:

  • Extracted template publishing logic into a new reusable workflow wc-publish-templates.yml
  • Simplified template IDs from cpp-template/rust-template to cpp/rust and names from amp-devcontainer-{lang} to the language name
  • Updated dependabot cooldown period from 5 to 7 days for both templates

Reviewed changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/wc-publish-templates.yml New reusable workflow that centralizes template publishing logic
.github/workflows/release-build.yml Refactored to call the new reusable workflow instead of duplicating steps
templates/cpp/devcontainer-template.json Simplified template ID and name, removed publisher field, formatted arrays inline
templates/rust/devcontainer-template.json Simplified template ID and name, removed publisher field, formatted arrays inline
templates/cpp/.github/dependabot.yml Increased cooldown period from 5 to 7 days
templates/rust/.github/dependabot.yml Increased cooldown period from 5 to 7 days

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 21 0 0 0.5s
✅ DOCKERFILE hadolint 3 0 0 0.68s
✅ GHERKIN gherkin-lint 6 0 0 2.31s
✅ JSON npm-package-json-lint yes no no 0.3s
✅ JSON prettier 21 2 0 0 0.34s
✅ JSON v8r 21 0 0 84.56s
✅ MARKDOWN markdownlint 12 0 0 0 0.82s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.2s
✅ REPOSITORY checkov yes no no 16.22s
✅ REPOSITORY gitleaks yes no no 0.52s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 28.68s
✅ REPOSITORY secretlint yes no no 0.9s
✅ REPOSITORY syft yes no no 1.85s
✅ REPOSITORY trivy yes no no 5.49s
✅ REPOSITORY trivy-sbom yes no no 0.23s
✅ REPOSITORY trufflehog yes no no 2.24s
⚠️ SPELL lychee 81 2 0 11.41s
✅ YAML prettier 29 0 0 0 0.91s
✅ YAML v8r 29 0 0 7.35s
✅ YAML yamllint 29 0 0 0.74s

Detailed Issues

⚠️ SPELL / lychee - 2 errors
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....122
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........2

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

Errors in README.md
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1132

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 173.95 MB 173.95 MB +75 B (+0%) 🔼
linux/arm64 166.46 MB 166.46 MB 1.92 kB (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1132

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 554.36 MB 554.36 MB +165 B (+0%) 🔼
linux/arm64 508.59 MB 508.59 MB 2.2 kB (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1132

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 688.94 MB 688.94 MB +1.16 kB (+0%) 🔼
linux/arm64 670.43 MB 670.43 MB 1.31 kB (0%) 🔽

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Test Results

 7 files  ±0   7 suites  ±0   4m 3s ⏱️ +15s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
69 runs  ±0  69 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 40ca7e3. ± Comparison against base commit c0081cf.

♻️ This comment has been updated with latest results.

Copilot AI review requested due to automatic review settings February 3, 2026 14:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 11 changed files in this pull request and generated 3 comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

Copy link
Member

@danielschenk danielschenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only wonder what the publisher field did and why it is removed, looks good otherwise.

@rjaegers
Copy link
Member Author

rjaegers commented Feb 4, 2026

Only wonder what the publisher field did and why it is removed, looks good otherwise.

Probably nothing, I looked at other templates and they left that field out. I don't even know if it is supported.

@rjaegers rjaegers added this pull request to the merge queue Feb 4, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2026
* fix: update devcontainer template structure

* chore: fix linter findings

* chore: correct hadolint execlude regex

* chore: fix line endings
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@rjaegers rjaegers added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@rjaegers rjaegers added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit ef21f17 Feb 4, 2026
49 checks passed
@rjaegers rjaegers deleted the fix/update-devcontainer-templates-structure branch February 4, 2026 16:52
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Pull Request Report (#1132)

Static measures

Description Value
Number of added lines 44
Number of deleted lines 40
Number of changed files 11
Number of commits 4
Number of reviews 4
Number of comments (w/o review comments) 7
Number of reviews that contains a comment to resolve 3
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 7

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.1 Days
Time that was spend on the branch before the PR was created 51 Sec
Time that was spend on the branch before the PR was merged 1.1 Days
Time to merge after last review 1.5 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 52.2 Min
Total time spend in last status check run on PR 20.4 Min

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

🎉 Hooray! The changes in this pull request went live with the release of v6.7.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants