Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a first run notice detailing the version of amp-devcontainer #688

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jan 9, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR adds a first-run-notice file that will be displayed when the container is first started displaying the container version number.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner January 9, 2025 09:28
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 23s ⏱️ +3s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 636640d. ± Comparison against base commit 3bd04a5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 17 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.5s
✅ GHERKIN gherkin-lint 2 0 0.85s
✅ JSON npm-package-json-lint yes no 0.33s
✅ JSON prettier 15 1 0 0.34s
✅ JSON v8r 14 0 9.35s
✅ MARKDOWN markdownlint 8 0 0 0.84s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.22s
✅ REPOSITORY checkov yes no 15.1s
✅ REPOSITORY gitleaks yes no 0.89s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.71s
✅ REPOSITORY secretlint yes no 1.06s
✅ REPOSITORY syft yes no 1.14s
✅ REPOSITORY trivy yes no 5.8s
✅ REPOSITORY trivy-sbom yes no 0.07s
✅ REPOSITORY trufflehog yes no 4.04s
✅ SPELL lychee 60 0 15.62s
✅ YAML prettier 22 0 0 0.63s
✅ YAML v8r 22 0 6.27s
✅ YAML yamllint 22 0 0.4s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:cd13b8b48a5d5b21e1a4180980c8b1c5984eea119c076541948490553c2ee57f

OS/Platform Previous Size Current Size Delta
linux/amd64 475.28M 475.28M 766.00 (+0.00%)
linux/arm64 614.64M 614.64M 766.00 (+0.00%)

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:9ccaadd48391c00e297bb2230849c912cf2cab7561e92007addb9c1ea713d9ef

OS/Platform Previous Size Current Size Delta
linux/amd64 686.88M 686.88M 752.00 (+0.00%)
linux/arm64 668.62M 668.62M 764.00 (+0.00%)

@rjaegers rjaegers marked this pull request as draft January 9, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant