Optimize HTMLTree updates and deletions#685
Closed
preciz wants to merge 1 commit intophilss:mainfrom
Closed
Conversation
- Replace macro put_in/2 with explicit Map.put/3 update syntax in patch_nodes/2 for faster static map updates. - Replace Map.take/2 and Map.values/1 pipeline with a list comprehension in do_delete/3 for faster bulk node retrieval without intermediate allocations. These targeted optimizations provide an 5%-9% overall execution speed up to Floki's core mutation operations like Floki.find_and_update/3, Floki.filter_out/2, and Floki.attr/4 when manipulating large documents.
Contributor
Author
|
Will open another PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
put_in/2with explicitMap.put/3update syntax inpatch_nodes/2for faster static map updates.Map.take/2andMap.values/1pipeline with a list comprehension indo_delete/3for faster bulk node retrieval without intermediate allocations.These optimizations provide an 5%-9% overall execution speed up to Floki's core mutation operations like Floki.find_and_update/3, Floki.filter_out/2, and Floki.attr/4 when manipulating large documents.