Skip to content

Optimize selector traversal #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philss merged 1 commit into from
Apr 23, 2026
+10 −10
Merged

Optimize selector traversal #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/floki/finder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ defmodule Floki.Finder do
end

defp get_selector_nodes(%Selector.Combinator{match_type: :child}, html_node, _tree) do
Enum.reverse(html_node.children_nodes_ids)
html_node.children_nodes_ids
end

defp get_selector_nodes(%Selector.Combinator{match_type: :adjacent_sibling}, html_node, tree) do
Expand Down Expand Up @@ -373,7 +373,6 @@ defmodule Floki.Finder do
case get_node(node_id, tree) do
%{children_nodes_ids: children} when children != [] ->
do_get_descendant_ids(children, tree, [])
|> Enum.reverse()

_ ->
[]
Expand All @@ -383,16 +382,17 @@ defmodule Floki.Finder do
defp do_get_descendant_ids([], _tree, acc), do: acc

defp do_get_descendant_ids([node_id | rest], tree, acc) do
acc = do_get_descendant_ids(rest, tree, acc)
acc = [node_id | acc]
acc =
case get_node(node_id, tree) do
%{children_nodes_ids: children} when children != [] ->
do_get_descendant_ids(children, tree, acc)

case get_node(node_id, tree) do
%{children_nodes_ids: children} when children != [] ->
do_get_descendant_ids(children, tree, acc)
_ ->
acc
end

_ ->
acc
end
acc = [node_id | acc]
do_get_descendant_ids(rest, tree, acc)
end

@spec map(Floki.html_tree() | Floki.html_node(), function()) ::
Expand Down
Loading