This repository was archived by the owner on Jan 23, 2019. It is now read-only.
Handle potentially missing attributes for (currently) un-supported platforms #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenny-evitt
force-pushed
the
fix-compile-for-unsupported-platforms
branch
from
dcc0c17 to
2d8a918
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this cookbook with an application cookbook that I've been using with computers running Ubuntu. But I'm working on another wrapper cookbook for setting-up development instances of my application and I'd like to support Mac OS and Windows as well as Linux (Ubuntu). I'm interested in working on adding Mac OS and Windows support to this cookbook but in the meantime I'd like to be able to implement 'hard-coded' support for those platforms and use this cookbook for Linux. Unfortunately, this cookbook can't be compiled by Chef on non-Linux platforms because of unguarded attribute access for attributes that only exist for Linux nodes. These changes should fix the compilation errors on currently un-supported platforms; they do on a Mac OS X computer I have.