Skip to content

fix: handle_refresh to handle potential errors in OS monitoring data retrieval #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle_refresh to handle potential errors in OS monitoring data retrieval #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions lib/phoenix/live_dashboard/pages/os_mon_page.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,20 @@ defmodule Phoenix.LiveDashboard.OSMonPage do

@impl true
def handle_refresh(socket) do
os_mon = SystemInfo.fetch_os_mon_info(socket.assigns.page.node)

socket =
assign(socket,
cpu: calculate_cpu_data(os_mon),
mem_usages: calculate_memory_usage(os_mon.system_mem),
disk_usages: calculate_disk_usage(os_mon.disk)
)

{:noreply, socket}
case SystemInfo.fetch_os_mon_info(socket.assigns.page.node) do
os_mon when is_map(os_mon) ->
socket =
assign(socket,
cpu: calculate_cpu_data(os_mon),
mem_usages: calculate_memory_usage(os_mon.system_mem),
disk_usages: calculate_disk_usage(os_mon.disk)
)

{:noreply, socket}

_ ->
{:noreply, socket}
end
end

defp calculate_cpu_data(%{cpu_avg1: num1, cpu_avg5: num5, cpu_avg15: num15} = os_mon)
Expand Down
Loading