Skip to content

Use existing function to call photon mosaic#69

Merged
alessandrofelder merged 10 commits intomainfrom
further-tests-cleanup
Mar 11, 2026
Merged

Use existing function to call photon mosaic#69
alessandrofelder merged 10 commits intomainfrom
further-tests-cleanup

Conversation

@lauraporta
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Working on tests I spotted a few improvements I could do in the tests and I've made a separate PR.

What does this PR do?

  • Moved the run_photon_mosaic helper function from tests/test_unit/test_metadata.py to tests/conftest.py, allowing all tests to import and use it instead of duplicating code.
  • Updated integration tests in tests/test_integration/test_whole_workflow.py to use the centralized run_photon_mosaic helper instead of manually constructing subprocess calls.
  • Removed the unused map_of_tiffs fixture from tests/conftest.py to reduce clutter and confusion.

How has this PR been tested?

Local test run

Is this a breaking change?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@lauraporta lauraporta marked this pull request as ready for review November 18, 2025 18:23
@lauraporta
Copy link
Member Author

@alessandrofelder, PR is ready for review 🙂

@alessandrofelder
Copy link
Contributor

Tried to quickfix the windows CI failure by enforcing use of bash, but we should check whether we really need pwd 🤔 (if that is indeed the issue)

@alessandrofelder
Copy link
Contributor

Hopefully after including fixes from #77 CI will now pass, and we can merge 🤞

Copy link
Contributor

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauraporta - I am happy with this now 🎉

@alessandrofelder alessandrofelder merged commit 724689e into main Mar 11, 2026
12 checks passed
@alessandrofelder alessandrofelder deleted the further-tests-cleanup branch March 11, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants