Use existing function to call photon mosaic#69
Merged
alessandrofelder merged 10 commits intomainfrom Mar 11, 2026
Merged
Conversation
Member
Author
|
@alessandrofelder, PR is ready for review 🙂 |
Specify bash as the shell for the test action.
Contributor
|
Tried to quickfix the windows CI failure by enforcing use of bash, but we should check whether we really need |
Contributor
|
Hopefully after including fixes from #77 CI will now pass, and we can merge 🤞 |
alessandrofelder
approved these changes
Mar 11, 2026
Contributor
alessandrofelder
left a comment
There was a problem hiding this comment.
Thanks @lauraporta - I am happy with this now 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Working on tests I spotted a few improvements I could do in the tests and I've made a separate PR.
What does this PR do?
run_photon_mosaichelper function fromtests/test_unit/test_metadata.pytotests/conftest.py, allowing all tests to import and use it instead of duplicating code.tests/test_integration/test_whole_workflow.pyto use the centralizedrun_photon_mosaichelper instead of manually constructing subprocess calls.map_of_tiffsfixture fromtests/conftest.pyto reduce clutter and confusion.How has this PR been tested?
Local test run
Is this a breaking change?
No
Checklist: