Fix ProfileClient creation with callable factory #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Apr 19, 2017
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Good!
I had just a smaller comment
|
|
||
| public function testCreateClientFromCallable() | ||
| { | ||
| $factory = function () { |
Member
There was a problem hiding this comment.
Use a argument here to make sure call_user_func passes an argument
Contributor
Author
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProfileClientFactory added in #136 was not tested and contained an error while decorating a callable factory. This is now fixed with tests.