feat: Clean-up listener/subscriber after the test #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvorisek, I was able to replicate the issue, and I believe it should be resolved here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Now
MockDisablerconstructor has optional 2nd parametercallbackwhich will be executed once the test ends.We remove the listener (for old PHPUnit versions) and for newer - remove the subscriber. It stills heavily relies on the internals of PHPUnit and it might break at any point, but as so the whole package.
Tests are a bit tricky, basically we chain of three tests, so I do not need to register a mock function in set up.
First just register a mock and it should be clearer in tearDown;
so then, the second should have the counter === 1, as the mock has been disabled, and it should be removed at this point, so the 3rd test should remain with the same counter (=== 1) - and actually it was failing before before the 'callback' solution.